Use the Font Loading API in `MOZCENTRAL` builds, and `GENERIC` builds for Firefox version 63 and above (issue 9945, bug 1088663) #9982

Snuffleupagus · 2018-08-17T09:13:33Z

I was feeling bored, so this is an attempt at fixing issue #9945.

This PR refactor/modernize/clean-up the font loading code, and then adds MOZCENTRAL support for the Font Loading API on top. /cc @brendandahl

Note: For easier reviewing, I'd suggest looking at one commit at a time and also using the ?w=1 URL flag to reduce the size of the larger diffs.

Fixes #9945.

pdfjsbot · 2018-08-17T09:16:46Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/b431db91b057e35/output.txt

pdfjsbot · 2018-08-17T09:16:46Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/62508676d6db318/output.txt

pdfjsbot · 2018-08-17T09:46:54Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/b431db91b057e35/output.txt

Total script time: 30.12 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2018-08-17T09:52:39Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/62508676d6db318/output.txt

Total script time: 35.88 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2018-08-17T22:42:49Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/2a188b35bf07193/output.txt

pdfjsbot · 2018-08-17T22:50:08Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/2a188b35bf07193/output.txt

Total script time: 7.30 mins

Published

Viewer: http://54.67.70.0:8877/2a188b35bf07193/web/viewer.html

pdfjsbot · 2018-08-17T23:06:32Z

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/83d65b3cdfa74ed/output.txt

pdfjsbot · 2018-08-17T23:13:35Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/83d65b3cdfa74ed/output.txt

Total script time: 7.05 mins

Published

Viewer: http://54.67.70.0:8877/83d65b3cdfa74ed/web/viewer.html

pdfjsbot · 2018-08-21T11:42:59Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/77b00c5d5431f46/output.txt

pdfjsbot · 2018-08-21T11:42:59Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/34fa113572492dc/output.txt

pdfjsbot · 2018-08-21T12:14:13Z

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/77b00c5d5431f46/output.txt

Total script time: 31.22 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/77b00c5d5431f46/reftest-analyzer.html#web=eq.log

pdfjsbot · 2018-08-21T12:19:22Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/34fa113572492dc/output.txt

Total script time: 36.37 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

brendandahl · 2018-08-22T21:20:53Z

src/display/font_loader.js

-        return null;
-      }
+  createNativeFontFace() {
+    if (typeof PDFJSDev !== 'undefined' && PDFJSDev.test('MOZCENTRAL')) {


Doesn't this need to be removed?

D'uh, this is such a rookie mistake on my part; thank you for spotting this!

pdfjsbot · 2018-08-24T13:50:05Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/1dbb624d51433b0/output.txt

pdfjsbot · 2018-08-24T13:50:05Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/3888a4b8650bb73/output.txt

pdfjsbot · 2018-08-24T14:14:35Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/3888a4b8650bb73/output.txt

Total script time: 24.49 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2018-08-24T14:47:44Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/1dbb624d51433b0/output.txt

Total script time: 57.65 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

Snuffleupagus · 2018-08-29T13:38:40Z

/botio-windows preview

pdfjsbot · 2018-08-29T13:38:41Z

From: Bot.io (Windows)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/12e74d2a4615639/output.txt

pdfjsbot · 2018-08-29T13:43:01Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/12e74d2a4615639/output.txt

Total script time: 4.31 mins

Published

Viewer: http://54.215.176.217:8877/12e74d2a4615639/web/viewer.html

pdfjsbot · 2018-09-10T11:43:53Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/73db6c45a3dcfae/output.txt

pdfjsbot · 2018-09-10T11:43:53Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/9f3266d8ef21648/output.txt

pdfjsbot · 2018-09-10T12:08:37Z

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/9f3266d8ef21648/output.txt

Total script time: 24.72 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/9f3266d8ef21648/reftest-analyzer.html#web=eq.log

pdfjsbot · 2018-09-10T12:20:07Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/73db6c45a3dcfae/output.txt

Total script time: 36.22 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

mark-i-m · 2018-09-18T17:46:27Z

Any progress on this? It would be nice to have the printing issues fixed. Thanks!

brendandahl · 2018-09-19T19:28:19Z

I want to hold off on this until the end of the week so #9340 has more time to bake in Firefox Nightly. It was a pretty large change and it will be easier to see if any regression come from it or this change if they are spread out a bit.

Also changes `var` to `let`/`const` in code already touched in the patch, and makes use of template strings in a few spots.

….missingFile` property The `Font.loading` property is only ever used *once* in the code, whereas `Font.missingFile` is more widely used. Furthermore the name `loading` feels, at least to me, slight less clear than `missingFile`. Finally, note that these two properties are the inverse of each other.

The `started` timestamp is completely usused, and the `end` timestamp is currently[1] being used essentially like a boolean value. Hence this code can be simplified to use an actual boolean value instead, which avoids potentially hundreds (or even thousands) of unnecessary `Date.now()` calls. --- [1] Looking briefly at the history of this code, I cannot tell if the timestamps themselves were ever used for anything (except for tracking "boolean" state).

Also changes `var` to `let`/`const` in code already touched in the patch, and makes use of template strings in a few spots.

… for Firefox version 63 and above (issue 9945)

https://github.com/zloirock/core-js#ecmascript-symbol

Snuffleupagus · 2018-09-29T14:50:23Z

/botio test

pdfjsbot · 2018-09-29T14:50:24Z

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.67.70.0:8877/d9d4519857d6576/output.txt

pdfjsbot · 2018-09-29T14:50:24Z

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.215.176.217:8877/fd237d43fc477b7/output.txt

pdfjsbot · 2018-09-29T15:10:03Z

From: Bot.io (Linux m4)

Success

Full output at http://54.67.70.0:8877/d9d4519857d6576/output.txt

Total script time: 19.64 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

pdfjsbot · 2018-09-29T15:14:28Z

From: Bot.io (Windows)

Failed

Full output at http://54.215.176.217:8877/fd237d43fc477b7/output.txt

Total script time: 24.05 mins

Font tests: Passed
Unit tests: Passed
Regression tests: FAILED

Image differences available at: http://54.215.176.217:8877/fd237d43fc477b7/reftest-analyzer.html#web=eq.log

brendandahl · 2018-10-01T18:09:30Z

/botio-windows test

pdfjsbot · 2018-10-01T18:09:31Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/52b4e3802f0ad74/output.txt

pdfjsbot · 2018-10-01T18:33:34Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/52b4e3802f0ad74/output.txt

Total script time: 24.03 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

brendandahl · 2018-10-01T18:38:22Z

/botio-windows test

pdfjsbot · 2018-10-01T18:38:23Z

From: Bot.io (Windows)

Received

Command cmd_test from @brendandahl received. Current queue size: 0

Live output at: http://54.215.176.217:8877/6ad32510d2e1809/output.txt

pdfjsbot · 2018-10-01T19:02:12Z

From: Bot.io (Windows)

Success

Full output at http://54.215.176.217:8877/6ad32510d2e1809/output.txt

Total script time: 23.81 mins

Font tests: Passed
Unit tests: Passed
Regression tests: Passed

timvandermeij added the core label Aug 17, 2018

Snuffleupagus force-pushed the mozcentral-FontLoadingAPI branch from 49e69ea to 3ba0d79 Compare August 17, 2018 23:03

Snuffleupagus force-pushed the mozcentral-FontLoadingAPI branch from 3ba0d79 to 556c9a4 Compare August 20, 2018 10:16

brendandahl suggested changes Aug 22, 2018

View reviewed changes

Snuffleupagus force-pushed the mozcentral-FontLoadingAPI branch 3 times, most recently from 5cc1895 to 20a46f9 Compare August 23, 2018 09:17

timvandermeij mentioned this pull request Aug 30, 2018

Low print quality for texts, maybe fonts not rendered correctly. #6498

Closed

Snuffleupagus force-pushed the mozcentral-FontLoadingAPI branch 3 times, most recently from c472879 to cb29a68 Compare September 3, 2018 07:58

Snuffleupagus force-pushed the mozcentral-FontLoadingAPI branch from fea36ee to fe69735 Compare September 10, 2018 11:40

Snuffleupagus changed the title ~~Use the Font Loading API in MOZCENTRAL builds, and GENERIC builds for Firefox version 63 and above (issue 9945)~~ Use the Font Loading API in MOZCENTRAL builds, and GENERIC builds for Firefox version 63 and above (issue 9945, bug 1088663) Sep 10, 2018

Snuffleupagus force-pushed the mozcentral-FontLoadingAPI branch from fe69735 to f027494 Compare September 16, 2018 18:16

Snuffleupagus force-pushed the mozcentral-FontLoadingAPI branch from f027494 to 0fbd95a Compare September 27, 2018 23:53

Snuffleupagus added 6 commits September 29, 2018 15:57

Convert FontFaceObject to an ES6 class

caf90ff

Also changes `var` to `let`/`const` in code already touched in the patch, and makes use of template strings in a few spots.

Refactor the FontLoader into proper, build-specific, ES6 classes

05b021b

Also changes `var` to `let`/`const` in code already touched in the patch, and makes use of template strings in a few spots.

Use the Font Loading API in MOZCENTRAL builds, and GENERIC builds…

435ec6a

… for Firefox version 63 and above (issue 9945)

Add a Symbol polyfill, using core-js, to allow using for...of loops

d6f4d2f

https://github.com/zloirock/core-js#ecmascript-symbol

Snuffleupagus force-pushed the mozcentral-FontLoadingAPI branch from 0fbd95a to d6f4d2f Compare September 29, 2018 14:06

brendandahl merged commit 25446db into mozilla:master Oct 1, 2018

Snuffleupagus deleted the mozcentral-FontLoadingAPI branch October 2, 2018 11:05

Use the Font Loading API in MOZCENTRAL builds, and GENERIC builds for Firefox version 63 and above (issue 9945, bug 1088663) #9982

Use the Font Loading API in MOZCENTRAL builds, and GENERIC builds for Firefox version 63 and above (issue 9945, bug 1088663) #9982

Conversation

Snuffleupagus commented Aug 17, 2018 • edited Loading

pdfjsbot commented Aug 17, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Aug 17, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 17, 2018

From: Bot.io (Windows)

Success

pdfjsbot commented Aug 17, 2018

From: Bot.io (Linux m4)

Success

pdfjsbot commented Aug 17, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 17, 2018

From: Bot.io (Linux m4)

Success

Published

pdfjsbot commented Aug 17, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 17, 2018

From: Bot.io (Linux m4)

Success

Published

pdfjsbot commented Aug 21, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Aug 21, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 21, 2018

From: Bot.io (Windows)

Failed

pdfjsbot commented Aug 21, 2018

From: Bot.io (Linux m4)

Success

brendandahl Aug 22, 2018

Choose a reason for hiding this comment

Snuffleupagus Aug 22, 2018

Choose a reason for hiding this comment

pdfjsbot commented Aug 24, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Aug 24, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Aug 24, 2018

From: Bot.io (Windows)

Success

pdfjsbot commented Aug 24, 2018

From: Bot.io (Linux m4)

Success

Snuffleupagus commented Aug 29, 2018

pdfjsbot commented Aug 29, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Aug 29, 2018

From: Bot.io (Windows)

Success

Published

pdfjsbot commented Sep 10, 2018

From: Bot.io (Linux m4)

Received

pdfjsbot commented Sep 10, 2018

From: Bot.io (Windows)

Received

pdfjsbot commented Sep 10, 2018

From: Bot.io (Windows)

Failed

pdfjsbot commented Sep 10, 2018

From: Bot.io (Linux m4)

Success

mark-i-m commented Sep 18, 2018

brendandahl commented Sep 19, 2018

Use the Font Loading API in `MOZCENTRAL` builds, and `GENERIC` builds for Firefox version 63 and above (issue 9945, bug 1088663) #9982

Use the Font Loading API in `MOZCENTRAL` builds, and `GENERIC` builds for Firefox version 63 and above (issue 9945, bug 1088663) #9982

Snuffleupagus commented Aug 17, 2018 •

edited

Loading