Skip to content
This repository has been archived by the owner on May 10, 2019. It is now read-only.

Dialog jank during signin animation on Chrome only #3668

Open
jaredhirsch opened this issue Jul 16, 2013 · 8 comments
Open

Dialog jank during signin animation on Chrome only #3668

jaredhirsch opened this issue Jul 16, 2013 · 8 comments

Comments

@jaredhirsch
Copy link
Member

When the chevron ( div.arrow or div.arrowContainer ) animates rightward after a successful login, you can see a flashing dark vertical line move across the dialog, too.

I can't repro on Safari or FF, but it's bad on Chrome/Mac. I'm not having luck getting a screen capture of the animation in progress.

@edwindotcom
Copy link
Contributor

i'm see a hard line at all times on FF beta with Retina
screen shot 2013-07-18 at 9 46 37 am

@vladikoff
Copy link

http://screencast.com/t/QBjoWJ64Tam uploaded a video demo, you can see the line show up right in the end

@mattbasta
Copy link

+1 on this. I see this on every browser that I use. Seems like a rounding error; increasing the value by half a pixel should probably fix it.

@jaredhirsch
Copy link
Member Author

@mattbasta This animation is based on CSS transitions, I think we've got a funky webkit bug here.

Not sure what you mean about a rounding error--this vertical line isn't visible (for me) except during the slide animation. Care to elaborate?

@jaredhirsch
Copy link
Member Author

@mattbasta actually, I think I get what you were saying. If I reposition the arrow 1 px to the left, I can't repro the line. Probably a subpixel rendering error because there's no overlap between the elements--I guess this is what you were talking about. Thanks for the hint 🍻

jaredhirsch added a commit to jaredhirsch/browserid that referenced this issue Jul 30, 2013
@mattbasta
Copy link

If I reposition the arrow 1 px to the left, I can't repro the line.

Yep, that's it. Thanks for this, I tried digging for the CSS and fixing it myself but mucking with production stylesheets made me lose interest :)

seanmonstar added a commit that referenced this issue Jul 30, 2013
Add arrow overlap to avoid animation flicker. Fixes #3668.
@bnolan
Copy link

bnolan commented Dec 16, 2015

Im still getting this in safari.
screen shot 2015-12-17 at 11 56 29 am

@shane-tomlinson
Copy link

This is still seen, re-opening.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants