Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Fluent source editor with syntax highlighting, error annotations #2180

Open
bugzilla-to-github opened this issue Sep 17, 2019 · 5 comments · Fixed by #2866
Open

Improve Fluent source editor with syntax highlighting, error annotations #2180

bugzilla-to-github opened this issue Sep 17, 2019 · 5 comments · Fixed by #2866
Assignees
Labels
enhancement FTL P3 Default, possibly shipping in the following two quarters

Comments

@bugzilla-to-github
Copy link
Collaborator

This issue was created automatically by a script.

Bug 1581911

Bug Reporter: @mathjazz
CC: @stasm, v+mozbug@g.nevcal.com

As part of fixing bug 1563457 we replaced Ace Editor with <textarea> element in order to support all scripts properly.

While that fixed the bug, it also removed syntax highlighting and error annotations from Fluent source editor.

We should find a solution similar to Ace Editor, that will support:

  1. All scripts.
  2. Fluent syntax highlighting.
  3. Fluent error annotations.
  4. (If possible) browser's spell- and grammar checkers (bug 1556355).
@bugzilla-to-github
Copy link
Collaborator Author

Comment Author: @mathjazz

A potential candidate with support for varying character widths is https://codemirror.net/.

@bugzilla-to-github
Copy link
Collaborator Author

Comment Author: Florencia Di Ciocco, NI to vbalducci <florencia.diciocco@softvision.com>

*** Bug #1586556 has been marked as a duplicate of this bug. ***

@bugzilla-to-github
Copy link
Collaborator Author

Comment Author: @stasm

Another candidate to consider might be Monaco, which powers VS Code: https://microsoft.github.io/monaco-editor/index.html

@mathjazz mathjazz changed the title [FTL] Improve Fluent source editor with syntax highlighting, error annotations Improve Fluent source editor with syntax highlighting, error annotations Nov 10, 2021
@mathjazz mathjazz added the FTL label Nov 10, 2021
@eemeli eemeli self-assigned this Jan 26, 2023
@mathjazz mathjazz moved this to 🔖 Ready in Pontoon Roadmap Feb 28, 2023
@eemeli eemeli added P2 We want to ship it soon, possibly in the current quarter and removed P3 Default, possibly shipping in the following two quarters labels May 26, 2023
@eemeli eemeli linked a pull request May 29, 2023 that will close this issue
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Pontoon Roadmap Jun 15, 2023
@eemeli
Copy link
Member

eemeli commented Jun 16, 2023

Not actually completely solved yet.

@eemeli eemeli reopened this Jun 16, 2023
@mathjazz mathjazz moved this from ✅ Done to 🏗 In progress in Pontoon Roadmap Sep 4, 2023
@mathjazz
Copy link
Collaborator

To make it clear, the remaining bit are inline Fluent error annotations.

If possible, we should also spell-check content only (and ignore syntax).

@mathjazz mathjazz added P3 Default, possibly shipping in the following two quarters and removed P2 We want to ship it soon, possibly in the current quarter labels Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement FTL P3 Default, possibly shipping in the following two quarters
Projects
Status: 🏗 In progress
Development

Successfully merging a pull request may close this issue.

3 participants