Add syntax highlighting for placeholders and tags #2879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathjazz
reviewed
Jun 19, 2023
translate/src/modules/translationform/utils/editFieldExtensions.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Matjaž Horvat <matjaz.horvat@gmail.com>
mathjazz
approved these changes
Jun 19, 2023
mathjazz
added a commit
to mathjazz/pontoon
that referenced
this pull request
Jun 20, 2023
…)" This reverts commit 9220827.
mathjazz
added a commit
to mathjazz/pontoon
that referenced
this pull request
Jun 22, 2023
…)" This reverts commit 9220827.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes part of #2180
These use a a CodeMirror 5-style stream parser or tokenizer, as that seemed like the easiest solution for the level of complexity we need. As these have a slightly different shape than our other parsers, and as our current regexps are somewhat suboptimal as identified in mozilla/react-content-marker#23, I wrote new ones for use here. Fluent patterns are handled specially, while all others are parsed for printf and Python-style variables. HTML-ish tags are identified in both.
Happy to take instruction on the CSS styles used by the highlighter.
Some examples: