Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

After sending a comment, the text remains in the input field #2519

Closed
flodolo opened this issue May 7, 2022 · 3 comments · Fixed by #2521
Closed

After sending a comment, the text remains in the input field #2519

flodolo opened this issue May 7, 2022 · 3 comments · Fixed by #2521
Assignees
Labels
bug P2 We want to ship it soon, possibly in the current quarter

Comments

@flodolo
Copy link
Collaborator

flodolo commented May 7, 2022

Type a comment and send it. The text will then be displayed again in the input field, below the comment just sent.

I'm pretty confident this is a regression.

@eemeli
Copy link
Member

eemeli commented May 7, 2022

Yeah, this appears to be due to an upstream change: ianstormtaylor/slate#4612. We'll need to add a workaround for it.

@mathjazz
Copy link
Collaborator

mathjazz commented May 7, 2022

Ouch. I broke that in 03435d9, which was a security update.

@eemeli Do you want to look into it?

@eemeli eemeli self-assigned this May 7, 2022
@eemeli eemeli added P2 We want to ship it soon, possibly in the current quarter bug labels May 7, 2022
@mathjazz
Copy link
Collaborator

mathjazz commented May 9, 2022

Relatedly, I also noticed that the comment input field is now too wide. On macos horizontal scrollbar appears briefly, and I guess it's always visible in other OSes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P2 We want to ship it soon, possibly in the current quarter
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants