Fix issues with comments #2521
Merged
Fix issues with comments #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #2520, will be rebased once that's merged; only the last two commits are actually meant for this PR.
Fixes #2519 by using a
keyprop on theSlatecomponent.Reduces prop-passing by adding a
useAddCommentAndRefershhook and refactoring the component structure aroundAddCommentand de-generalisingCommentsListso thatTeamCommentscan do its own thing with pinned comments.I also noticed that while the comment mention popup does get hidden if it's scrolled out of sight, it's not re-shown if scrolled back. That's also fixed here.