Add support for list query parameter #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eemeli
force-pushed
the
list-entities
branch
2 times, most recently
from
3b4e4c2
to
05becc0
Compare
mathjazz
approved these changes
May 12, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on #2518, will be rebased once that's merged; only the last two commits are actually meant for this PR.
Fixes #2049 by adding support for a
list=13,42,99URL query parameter. This is then used by the review-notification links, as discussed previously in #2456 (comment).In the UI, the list view is indicated by a custom search-box icon,
list-alt:Internally, the argument uses the existing
entity_idspayload parameter used by batch actions, with which/get-entities/returns an unpaginated list of matching entities. It's not possible to use the parameter together with any other filters likestatusorsearch. This allows for re-merging the just-addedfetchEntitiesById()API wrapper method intofetchEntities().An errant missing FiltersPanel FTL string is added, as we're meddling here with that code in any case.