Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1698074, run flow-to-ts in automation to keep track of errors #1891

Merged
merged 9 commits into from
Mar 12, 2021

Conversation

Pike
Copy link
Collaborator

@Pike Pike commented Mar 12, 2021

No description provided.

@Pike Pike marked this pull request as ready for review March 12, 2021 12:08
@Pike Pike requested a review from mathjazz March 12, 2021 12:08
@Pike
Copy link
Collaborator Author

Pike commented Mar 12, 2021

I think this is a good-enough starting point. I haven't yet figured out how to get an error count, but right now this is at 767 TS errors.

@Pike Pike self-assigned this Mar 12, 2021
Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Why do you need to git commit the changes before running the script? And why do you need to run git diff (to debug?)?

Also, a bug explaining the motivation or a comment in bug 1685565 would be welcome.

},
"include": ["src"]
}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess the empty line is not empty?

@Pike Pike changed the title Run flow-to-ts in automation to keep track of errors Bug 1698074, run flow-to-ts in automation to keep track of errors Mar 12, 2021
@Pike
Copy link
Collaborator Author

Pike commented Mar 12, 2021

Why do you need to git commit the changes before running the script? And why do you need to run git diff (to debug?)?

I want to add visibility into what the steps do, and what the code looks like that is creating errors. The commit and diff on the first step is just for the sake of completeness. I really care about exposing the changes that flow-to-ts does, but sadly git didn't cooperate with me at all so far. That's what that's commented out.

Maybe I'll use https://git-scm.com/docs/git-bundle, but I didn't want to spend too much time on this workflow for now, and rather iterate. I found it more interesting to get the flow up, so that we can use it in April's PR.

Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for clarifying!

@mathjazz mathjazz merged commit 5ebd22e into mozilla:master Mar 12, 2021
@Pike Pike deleted the flow-to-ts-automation branch March 16, 2021 17:54
@Pike Pike added the typescript PRs related to the conversion to TypeScript label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript PRs related to the conversion to TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants