-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1698074, run flow-to-ts in automation to keep track of errors #1891
Conversation
I think this is a good-enough starting point. I haven't yet figured out how to get an error count, but right now this is at 767 TS errors. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Why do you need to git commit
the changes before running the script? And why do you need to run git diff
(to debug?)?
Also, a bug explaining the motivation or a comment in bug 1685565 would be welcome.
frontend/no-tsconfig.json
Outdated
}, | ||
"include": ["src"] | ||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess the empty line is not empty?
I want to add visibility into what the steps do, and what the code looks like that is creating errors. The commit and diff on the first step is just for the sake of completeness. I really care about exposing the changes that Maybe I'll use https://git-scm.com/docs/git-bundle, but I didn't want to spend too much time on this workflow for now, and rather iterate. I found it more interesting to get the flow up, so that we can use it in April's PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clarifying!
No description provided.