Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1698074, follow-up for prettier and diff #1896

Merged
merged 4 commits into from
Mar 16, 2021
Merged

Conversation

Pike
Copy link
Collaborator

@Pike Pike commented Mar 15, 2021

The problems I had with the diffs were a rather obscure limit of files that are allowed when diffing with moves. Bump that.

Also, the prettified version from flow-to-ts strips newlines, move the prettify call separate.

@Pike Pike marked this pull request as ready for review March 15, 2021 16:42
@Pike Pike requested a review from mathjazz March 15, 2021 16:43
@Pike
Copy link
Collaborator Author

Pike commented Mar 15, 2021

Got the diff to become useful. Khan/flow-to-ts#237 is all over the place, as well as some newly-multiline statements, I think.

Adding --ignore-blank-lines would reduce the size of the output, I guess. But it'd also make it harder to tell line numbers, so I'm not sure which is better.

Copy link
Collaborator

@mathjazz mathjazz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Nice catch with the file limit!

@mathjazz mathjazz merged commit fbf931b into mozilla:master Mar 16, 2021
@Pike Pike deleted the diff-on-ts branch March 16, 2021 11:17
@Pike Pike added the typescript PRs related to the conversion to TypeScript label May 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
typescript PRs related to the conversion to TypeScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants