Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Added an account disabled page #3391
base: main
Are you sure you want to change the base?
Feature: Added an account disabled page #3391
Changes from 12 commits
d76b3f9
3ac7caa
3ef5bd3
4feaf25
84ce15c
88316bd
ac0fcc1
b153657
bddfb0f
4ce40e6
919d0fd
08710a2
3b8d978
8c0f388
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What exactly does this code do? If the user is not authenticated, we shouldn't do anything.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mathjazz , I was having trouble running the code without this patch, mainly when the user is not active and wishes to login, it does not pass through the
AuthMiddleware
,did some digging and found that one of the requirements for a user to be authenticated is that the user must be active
I tried checking if both
is_active
andis_authenticated
is false, however, this sort of thing affectsAnonymousUser
's meaning they can't browse any pages if you aren't authenticated.So I updated the patch to have two parts just in case:
is_authenticated
and not activethe path highlighted presents the second part of the patch,