1584182: Move browser-storage-sync to support-sync-telemetry #122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbertsch
approved these changes
Sep 30, 2019
|
The library names currently match the Java/Android maven library names. But now that this is all internal, we probably don't need to do that and could remove that layer of indirection. (But that's probably a separate bug/PR...) |
|
Ah, this was causing the failures over the weekend! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in support of the changes in mozilla-mobile/android-components#4480.
tl;dr: The metrics that were formerly sent by
browser-storage-synchave been moved to a helper component insupport-sync-telemetry(which will in the future be used by other sync products).None of the metrics were actually renamed, so I think this is a safe, non-schema-changing transformation, but could you please confirm, @fbertsch ? This is the sort of change we haven't really anticipated...
Cc: @grigoryk