hide query more menu if empty (re #208)

mozilla · Oct 31, 2018 · 73970ea · 73970ea
1 parent 9fbc9f7
commit 73970ea
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/client/app/pages/queries/query.html b/client/app/pages/queries/query.html
@@ -45,7 +45,7 @@ <h3>
           </a>
         </span>
 
-        <div ng-if="query.id != undefined" class="btn-group" role="group" uib-dropdown>
+        <div ng-show="moreMenuIsPopulated()" id="query-more-menu" ng-if="query.id != undefined" class="btn-group" role="group" uib-dropdown>
           <button class="btn btn-default dropdown-toggle hidden-xs" uib-dropdown-toggle>
             <span class="zmdi zmdi-more"></span>
           </button>

diff --git a/client/app/pages/queries/view.js b/client/app/pages/queries/view.js
@@ -498,6 +498,17 @@ function QueryViewCtrl(
       },
     });
   };
+
+  $scope.moreMenuIsPopulated = () => {
+    const menuParent = document.getElementById('query-more-menu');
+
+    if (menuParent) {
+      if (menuParent.querySelectorAll('.dropdown-menu li').length) {
+        return true;
+      }
+    }
+    return false;
+  };
 }
 
 export default function init(ngModule) {