Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard showing up empty after hitting "publish" #25

Closed
sunahsuh opened this issue Dec 22, 2016 · 13 comments
Closed

Dashboard showing up empty after hitting "publish" #25

sunahsuh opened this issue Dec 22, 2016 · 13 comments
Milestone

Comments

@sunahsuh
Copy link

sunahsuh commented Dec 22, 2016

As reported by @davismtl -- he created this dashboard this afternoon and after he was done and hit publish, the graphs disappeared: https://sql.telemetry.mozilla.org/dashboard/fxa-login-signin-kpis

I ran this query to check and the visualizations seem to be linked correctly, at least at the DB level: https://sql.telemetry.mozilla.org/queries/1976/source

But the api call on the dashboard page appears to be empty:
https://sql.telemetry.mozilla.org/api/dashboards/fxa-login-signin-kpis
Response:

{"is_archived": false, "updated_at": "2016-12-21T23:27:26.711851+00:00", "layout": "[[1106, 1107], [1115, 1116], [1113], [1114, 1110], [1117, 1118], [1111, 1108]]", "is_draft": false, "id": 142, "can_edit": true, "user_id": 15, "name": "FxA: Overall (adavis)", "created_at": "2016-12-21T18:03:43.936011+00:00", "slug": "fxa-login-signin-kpis", "version": 30, "widgets": [[], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], [], []], "dashboard_filters_enabled": false}
@davismtl
Copy link

davismtl commented Dec 22, 2016

If it can help, I'm nearly certain the last chart I added before hitting publish was: https://sql.telemetry.mozilla.org/queries/1974/source#3528

This chart was in a "Draft" state at the time of publishing the dashboard. It was probably the only chart in a draft state at the time of publishing.

@davismtl
Copy link

Hey @sunahsuh , couple of questions:

  • How long do we think it will take to fix the dashboard?
  • If it will take a while, can you let me know what query or chart numbers were in it and in what order and perhaps I can remake it in the meantime.

Thanks for your help

@sunahsuh
Copy link
Author

Hey Alex, I'm not sure re: a fix -- the original idea was that someone on Data Tools that knows the codebase would investigate further.
I was able to re-create this list of chart urls, at least, from the IDs that are still stored in the DB: https://sql.telemetry.mozilla.org/queries/2010/source

@davismtl
Copy link

davismtl commented Jan 3, 2017

Thank you! This is super helpful!

@washort
Copy link

washort commented Jan 4, 2017

I'm having a look at this, going to see if it can be reproduced in a development environment.

@davismtl
Copy link

davismtl commented Jan 5, 2017

@rfk just experienced the same thing. Maybe he can add details here.

@rfk
Copy link

rfk commented Jan 5, 2017

Not sure I can add any more than a "+1", but it did seem to happen under the same set of circumstances as @davismtl described - adding draft charts to a draft dashboard, and publishing the dashboard without marking all the charts as published.

@washort
Copy link

washort commented Jan 6, 2017

My attempts to reproduce this so far haven't worked, publishing a draft dashboard with draft queries appears to work most of the time. Here's one, for example, with one of your draft queries in it: https://sql.telemetry.mozilla.org/dashboard/dashboard-bug-test?p_days=30

I'll keep digging.

@washort
Copy link

washort commented Jan 6, 2017

@robotblake identified the immediate problem: the layout field in the dashboard data structure was stored as a JSON string instead of a JSON list of widget ids. So the bug is probably in the dashboard-editing JS. A workaround for now would be to just fix up any existing layout fields malformed in this way while we track down the origin of this.

@rafrombrc rafrombrc added this to the next milestone Jan 20, 2017
@washort
Copy link

washort commented Jan 23, 2017

We're working on getting a newer version of redash deployed that should fix this.

@washort
Copy link

washort commented Apr 26, 2017

This Sentry error appears to be the same issue: https://sentry.prod.mozaws.net/operations/pipeline-sql-prod/issues/371388/

@washort washort reopened this Apr 26, 2017
@rafrombrc rafrombrc modified the milestones: 4.1, zero, 4.2 Apr 26, 2017
@rafrombrc rafrombrc modified the milestones: 4.3, 4.2 May 10, 2017
@madalincm
Copy link

I have verified all the above dashboards and all are looking good. Closing issue.

washort pushed a commit that referenced this issue Dec 12, 2017
washort pushed a commit that referenced this issue Dec 12, 2017
washort pushed a commit that referenced this issue Jan 8, 2018
washort pushed a commit that referenced this issue Jan 17, 2018
washort pushed a commit that referenced this issue Feb 6, 2018
washort pushed a commit that referenced this issue Feb 28, 2018
jezdez pushed a commit that referenced this issue Mar 5, 2018
emtwo pushed a commit that referenced this issue May 25, 2018
washort pushed a commit that referenced this issue Jul 25, 2018
@jezdez jezdez mentioned this issue Aug 15, 2018
wlach pushed a commit to wlach/redash that referenced this issue Jun 23, 2023
Create preview docker image on merge to master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants