IntegrityError: (psycopg2.IntegrityError) update or delete on table "query_results" violates foreign key constrai...

[jezdez]

Seems like the process to cleanup results is broken due to the result sets:

https://sentry.prod.mozaws.net/operations/data-stmo-prod/issues/3460864/

IntegrityError: (psycopg2.IntegrityError) update or delete on table "query_results" violates foreign key constraint "queries_latest_query_data_id_fkey" on table "queries"
DETAIL:  Key (id)=(3570734) is still referenced from table "queries".
 [SQL: 'DELETE FROM query_results WHERE query_results.id IN (SELECT query_results.id \nFROM query_results \nWHERE query_results.retrieved_at < %(retrieved_at_1)s AND NOT (EXISTS (SELECT 1 \nFROM query_resultsets \nWHERE query_resultsets.result_id = query_results.id)) \n LIMIT %(param_1)s)'] [parameters: {'retrieved_at_1': datetime.datetime(2018, 4, 2, 18, 35, 6, 406886), 'param_1': 100}]
(11 additional frame(s) were not displayed)
...
  File "sqlalchemy/engine/base.py", line 1189, in _execute_context
    context)
  File "sqlalchemy/engine/base.py", line 1393, in _handle_dbapi_exception
    exc_info
  File "sqlalchemy/util/compat.py", line 202, in raise_from_cause
    reraise(type(exception), exception, tb=exc_tb, cause=cause)
  File "sqlalchemy/engine/base.py", line 1182, in _execute_context
    context)
  File "sqlalchemy/engine/default.py", line 469, in do_execute
    cursor.execute(statement, parameters)

IntegrityError: (psycopg2.IntegrityError) update or delete on table "query_results" violates foreign key constraint "queries_latest_query_data_id_fkey" on table "queries"
DETAIL:  Key (id)=(3570734) is still referenced from table "queries".
 [SQL: 'DELETE FROM query_results WHERE query_results.id IN (SELECT query_results.id \nFROM query_results \nWHERE query_results.retrieved_at < %(retrieved_at_1)s AND NOT (EXISTS (SELECT 1 \nFROM query_resultsets \nWHERE query_resultsets.result_id = query_results.id)) \n LIMIT %(param_1)s)'] [parameters: {'retrieved_at_1': datetime.datetime(2018, 4, 2, 18, 35, 6, 406886), 'param_1': 100}]

[washort]

This was an oversight due to deficient tests when changing around the delete code to accommodate storing multiple results per query.