Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpublished queries can be added to dashboards from the query page #482

Closed
madalincm opened this issue Aug 1, 2018 · 4 comments
Closed
Assignees
Labels
Milestone

Comments

@madalincm
Copy link

Steps to Reproduce:

  1. Open an unpublished query: https://pipeline-sql.stage.mozaws.net/queries/394/source#486
  2. Click on the plus button next to the "Table" text
  3. Search for a dashboard and add the query to that dashboard
  4. Open the dashboard where you added the query: https://pipeline-sql.stage.mozaws.net/dashboard/dashboardunpublishedquery

Expected results:

The query is not added to the dashboard.

Actual results:

The query is added to the dashboard

Notes/Issues:

Verified in FF61(Win7). Issue can be reproduced in STMO-stage

@emtwo
Copy link

emtwo commented Aug 2, 2018

I confirmed that you can still add published queries which is most important. This is currently a feature that only exists in stmo but is in the process of being ported upstream (getredash#2656) I left a note there so that this is taken into account during the port.

@alison985 alison985 self-assigned this Sep 10, 2018
alison985 added a commit to StantonVentures/redash that referenced this issue Sep 10, 2018
@alison985
Copy link

This is now part of this upstream PR: getredash#2767

@alison985 alison985 added in review in review upstream PR in review in getredash/redash and removed in progress labels Sep 10, 2018
@rafrombrc rafrombrc modified the milestones: 17, 18 Nov 7, 2018
@rafrombrc
Copy link
Member

Made another request for review of the latest revisions, hope to see this merged v soon.

@rafrombrc rafrombrc modified the milestones: 18, 19 Nov 8, 2018
@alison985 alison985 removed in review in review upstream PR in review in getredash/redash labels Nov 11, 2018
@alison985
Copy link

This was merged upstream.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants