Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port query version comparison in the front-end #583

Closed
jezdez opened this issue Oct 5, 2018 · 4 comments
Closed

Port query version comparison in the front-end #583

jezdez opened this issue Oct 5, 2018 · 4 comments
Assignees
Labels
Milestone

Comments

@jezdez
Copy link

jezdez commented Oct 5, 2018

@alison985 alison985 self-assigned this Oct 15, 2018
@alison985
Copy link

Ported here: https://github.com/StantonVentures/redash/tree/moz_583_query_versions tests pass and npm run build succeeds, but I have a funky error with the query testarea not showing more than 2 lines of code.

@alison985
Copy link

Made a WIP PR upstream to try to get help with the textarea issue. getredash#3021

@rafrombrc rafrombrc added this to the 20 milestone Nov 9, 2018
@jezdez jezdez assigned jezdez and unassigned alison985 Jan 16, 2019
@rafrombrc rafrombrc modified the milestones: 20, 21 Feb 6, 2019
@rafrombrc
Copy link
Member

This needs to be react-ified and then to integrate some design changes that have been requested to better match the rest of redash design. This is a good job for Davor to tackle when he returns next week.

@rafrombrc rafrombrc assigned spasovski and unassigned jezdez Mar 8, 2019
@jezdez
Copy link
Author

jezdez commented May 5, 2020

We've decided to deprecate the feature for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants