WIP: Add Compare Query Versions Feature Upstream

[alison985]

This is a port from the Mozilla fork. Issue to port it upstream: mozilla#583

This PR adds the Compare Query Version feature to getredash. That includes:

1. Saving each saved version of the query.
2. Allowing folks to compare query versions and revert back to a previous query version.

This is listed as a WIP because of a rendering issue with the query editor textarea. I would like help with this part please.

[alison985]

Specifically, the textarea issue is confusing me because:
a) it works fine in Chrome 70.0.3538.77
b) when it shows up in Firefox 60.0.2 (64-bit) the way to fix it isn't code based but instead to re-size your browser window.

If you do a normal load of the page (or refresh), the screen looks like this, not showing the entire query string:

If you resize the browser window, it will correctly render like this:

[alison985]

@jezdez & @rafrombrc - This is a Firefox specific issue. Pointers on next steps would be appreciated.

[arikfr]

@alison985 can you please include some screenshots of the UI implemented here (and changes to existing one)?

[alison985]

@arikfr Here are screenshots of the compare query feature.

The menu on the edit query page:

Compare Query dialog when initially opened:

Compare Query dialog with a specific version chosen for comparison.

[kocsmy]

We'll need to modernise this interface so it fits our design.

• Can we use code coloring like it's in the editor?
• I have some ideas to improve the layout, too, I will provide a design later this week.

[kocsmy]

@alison985 here's an updated design proposal. Can we use ace editor as well for the code (I think there's a way to use it in a non-editable mode)?

[fjcero]

What about this?

[arikfr]

Hi,

(This is a template message, but I mean every word of it. Also you're welcome to reply)

Thank you for making this contribution. While we couldn't bring it to completion and merge, it's still very much appreciated. 🙇

In the past year the Redash code base gone under massive updates: on the backend we moved to Python 3 & RQ instead of Celery and on the frontend we replaced Angular with React. It's very likely this makes this PR irrelevant without significant changes. :-(

I'm closing this PR now. But if you're still interested in making it happen, let me know and I will reopen.

Thanks.

[jezdez]

Hey, can you elaborate if this is something you'd take?

EDIT to clarify: I meant whether such a feature would be still interesting to submit a PR for.

[arikfr]

Would we want a version history feature? Sure. But we should probably discuss UX & implementation before.

[jezdez]

Okay, great, I'll chat with the others soon and get back to you about it.

[fjcero]

@jezdez @arikfr If PRs are welcome, I will like to contrib!