Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unique names for query parameters (refs #164) #305

Merged
merged 1 commit into from
Mar 26, 2018
Merged

Conversation

washort
Copy link

@washort washort commented Jan 16, 2018

This puts the query ID in the URL parameters, so that when multiple queries in a dashboard have a parameter of the same name, they don't get confused.

(fixes #164)

@washort washort requested a review from jezdez January 16, 2018 22:08
@rafrombrc rafrombrc added this to the 13 milestone Jan 17, 2018
@washort
Copy link
Author

washort commented Jan 17, 2018

fixes #164

@washort washort force-pushed the master branch 2 times, most recently from 00e9297 to 08af871 Compare January 18, 2018 20:00
@washort washort force-pushed the unique-parameters-164 branch from d56f286 to 2c14058 Compare January 22, 2018 15:27
@washort
Copy link
Author

washort commented Jan 22, 2018

rebased onto master

@washort washort force-pushed the master branch 3 times, most recently from 2618326 to bf7370c Compare February 14, 2018 17:53
@jezdez jezdez changed the title Unique names for query parameters (re #164) Unique names for query parameters (refs #164) Feb 21, 2018
@washort washort force-pushed the unique-parameters-164 branch from 2c14058 to 365dec3 Compare February 22, 2018 20:08
@washort washort force-pushed the master branch 2 times, most recently from ecaaeda to ea9c225 Compare March 5, 2018 18:49
@jezdez jezdez force-pushed the master branch 2 times, most recently from 4ae2fe6 to 80d9ab6 Compare March 5, 2018 21:35
@washort washort force-pushed the unique-parameters-164 branch from 365dec3 to d233502 Compare March 6, 2018 18:30
@washort washort force-pushed the unique-parameters-164 branch from d233502 to 6d6205c Compare March 6, 2018 18:35
@emtwo emtwo self-assigned this Mar 21, 2018
@emtwo emtwo requested review from emtwo and removed request for jezdez March 26, 2018 19:21
Copy link

@emtwo emtwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good!

@emtwo emtwo added r+ review granted and removed in review labels Mar 26, 2018
@washort washort merged commit f2c80df into master Mar 26, 2018
@washort washort deleted the unique-parameters-164 branch March 26, 2018 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
r+ review granted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboards with templates behave strangely when refreshed
3 participants