Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show number of queries in queue while waiting for execution #786

Merged
merged 3 commits into from
Feb 25, 2019

Conversation

washort
Copy link

@washort washort commented Jan 25, 2019

This invokes the same API used in the admin "Running Queries" page to ask redis how many jobs are in the 'waiting' state ahead of the current one.

I tested this locally by stopping the celery worker and executing several queries.

@emtwo
Copy link

emtwo commented Jan 29, 2019

The code looks fine to me, I'll try it out locally as well. Just wondering if maybe we should be opening this up upstream? And perhaps we can add a small test for this.

@washort
Copy link
Author

washort commented Jan 30, 2019

I'd like to test this out in our deploy for a bit before sending it upstream. I've added a simple test for the API layer.

Copy link

@jezdez jezdez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for a test-drive.

@washort washort merged commit 7233ebb into master Feb 25, 2019
@washort washort deleted the execute-queue-status branch February 25, 2019 16:19
@jezdez jezdez mentioned this pull request Mar 26, 2019
6 tasks
@jezdez
Copy link

jezdez commented May 9, 2019

@washort @rafrombrc We never looked at this again since the test-drive, and the code isn't super ideal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants