Preserving cause on rethrown exceptions #1286
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an issue, that we loose the java stack trace, when we catch the error in javascript and rethrow it.
In this case, you will get a JavaScriptException with only the message containing of the exception, that is thrown by
someJavaObject.doSomething();
(So you might get a NPE, but you have no idea, which line of code caused the exception)
In this PR, we try to set the currently processing exception/NativeError and setting it as cause of the JavaScriptException.
Roland