Fixes for Symbol.iterator handling in NativeArray #1435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
rbri
commented
Jan 10, 2024
rbri
commented
- Array.prototype[Symbol.iterator] points to the 'values' functions
- arguments[Symbol.iterator] points to Array.prototype[Symbol.iterator] (see Correctly assign the value of arguments[Symbol.iterator] HtmlUnit/htmlunit-rhino-fork#14)
rbri
added a commit
to HtmlUnit/htmlunit-rhino-fork
that referenced
this pull request
Jan 11, 2024
|
I have to say that it didn't look right to me at first, but I checked the spec and my browser and it sure is. So thanks! |
:-D same here; JS is fun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.