NativeError: Add ES2022 cause
#1570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
camnwalter
force-pushed
the
error-cause
branch
from
6bbda32 to
f50994e
Compare
camnwalter
commented
Aug 21, 2024
| obj.setAttributes("cause", DONTENUM); | ||
| } | ||
| } else { | ||
| ScriptableObject.putProperty(obj, "fileName", ScriptRuntime.toString(args[1])); |
There was a problem hiding this comment.
Suggested change
| ScriptableObject.putProperty(obj, "fileName", ScriptRuntime.toString(args[1])); | |
| ScriptableObject.putProperty(obj, "fileName", args[1]); |
I changed this to convert the fileName argument to a string, which is what it looks like it does in Firefox but I can revert this back since it's a breaking change.
|
The CI pipeline fails due to formatting issues, see https://github.com/mozilla/rhino/actions/runs/10482059063/job/29037139925?pr=1570 |
camnwalter
force-pushed
the
error-cause
branch
from
f50994e to
ffb7253
Compare
|
Huh, I will fix those failing tests. |
This fixes a couple other test cases involving toString() as well.
camnwalter
force-pushed
the
error-cause
branch
from
ffb7253 to
730d734
Compare
|
+1 |
|
Looks good to me. I will try to merge it soon. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a couple other test cases involving toString() as well.
cause_abruptfails because it requires Proxy.As mentioned in #1091 (comment), I haven't changed toSource(), but I can add that functionality if that is wanted.
Resolves #1091