Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing Undefined.instance to ScriptRuntime.evalSpecial #1714

Merged
merged 1 commit into from
Oct 31, 2024
Merged

Allow passing Undefined.instance to ScriptRuntime.evalSpecial #1714

merged 1 commit into from
Oct 31, 2024

Conversation

andreabergia
Copy link
Contributor

The method ScriptRuntime.evalSpecial takes a generic Object for thisArg. However, it then casts it to Scriptable.
We have some (rare) code paths where we end up passing Undefined.instance to that method, where we get a ClassCastException.
This simple PR allows it and adds a test.

@gbrail
Copy link
Collaborator

gbrail commented Oct 31, 2024

Looks good to me too -- thanks!

@gbrail gbrail merged commit efa49df into mozilla:master Oct 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbri rbri rbri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andreabergia @gbrail @rbri