-
Notifications
You must be signed in to change notification settings - Fork 866
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert NativeObject
from IdScriptableObject
to lambda constructor.
#1824
base: master
Are you sure you want to change the base?
Convert NativeObject
from IdScriptableObject
to lambda constructor.
#1824
Conversation
This is directionally the right thing to do, and the right way to do it. As you can see from the test results, there are a bazillion legacy behaviors that need to be fixed when making a change like this, unfortunately. FWIW I was going to tackle fundamental classes like this later, but since you already did most of the work it'd be great to figure out what's holding back those tests that are now failing. Also, after that's all done, please run:
to regenerate the properties file! |
I’ve got benchmarks. Some better, some worse, but I think I understand why. Probably won’t get the test fixes done till the weekend. |
ccceda6
to
0d61dc9
Compare
@gbrail Everything is passing nicely except for one proxy test which looks at the result of That would be simple to fix by just changing the test, but the better long term solution might be to make our function |
i guess #1300 is exactly that story. maybe we have to address this in a separate PR |
dd79a9f
to
b5a00e2
Compare
@gbrail I'm creating this as a draft PR for now. There are 24 test failures from doc tests due to small changes in the
toString
results for various functions on object, and I'm not sure if we should work to reduce those differences or if we're fine with changing the tests.I'll update this PR with benchmark comparisons when I've had time to run the full suite.