ADD: NativeArray.subList() #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbri
reviewed
May 20, 2021
| throw new IllegalStateException(); | ||
| } | ||
| final int len = (int) longLen; | ||
| final int len = size(); |
There was a problem hiding this comment.
Looks like we have this pattern at more places, maybe we can remove the duplicated code at all places
toArray()
indexOf()
lastIndexOf()
And maybe we can add some text to the illegal state exception thrown in the size() method.
|
Can you address the comment from @rbri ? Other than that this seems fine, but I don't know enough about the guts of NativeArray to understand what this enables. |
tonygermano
reviewed
May 20, 2021
|
@gbrail can you take a look at this PR again? In my humble oppinion, all mentioned points should be solved now. |
|
Yes, this looks good. Thanks for working on it! |
p-bakker
added
feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the missing NativeArray.subList() functionality