fix #977 Support ES2019 JSON superset #978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice going! IMHO it doesn't need to check the languageVersion, as this is a change that previously would be a SyntaxError, thus it cannot really break existing implementations (just like the other two you mentioned are syntax or (global) object additions that don't alter existing behavior) |
|
Yes -- I agree that it's OK to add features like this because they result in code that used to not work working, as opposed to features that result in code that used to work stopping... I'll test this myself and get back... |
|
This looks good to me too. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #977
Is it necessary to check
compilerEnv.getLanguageVersion()?These do not seem to be checked.