Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for Apple M1 aarch64 #77

Closed
skhamis opened this issue Dec 14, 2021 · 3 comments
Closed

Support for Apple M1 aarch64 #77

skhamis opened this issue Dec 14, 2021 · 3 comments

Comments

@skhamis
Copy link
Contributor

skhamis commented Dec 14, 2021

Application-services is currently running into an issue with compiling NSS via rust-android-gradle mozilla/application-services#4665.

I believe it's potentially something to do with rust-android-gradle associating Darwin = x86_64 mozilla/application-services#4665 (comment) which works if the Mac is using a JDK = x86_64 but M1's are now defaulting to downloading arm64 (homebrew) JDKs which causes the builds to break.

We probably need to allow the ability for Darwin to = arm64

@ncalexan
Copy link
Member

@skhamis thanks for the report. As we discussed on Slack, I'm not aware of any fundamental blocker to making this work. My expectation is that we need to split darwin into darwin-{x86-64,aarch64}. We do run some tests in CI these days, but I'm not sure that we can target macOS aarch64 machines in Github Actions, nor am I sure that we're running any Robolectric style tests.

Let me know how you get on with a patch. Thanks!

@skhamis
Copy link
Contributor Author

skhamis commented Jan 4, 2022

@ncalexan I think it the PR ended up being pretty straightforward! To keep things straightforward and prevent anyone from breaking too bad. I decided to go with keeping darwin and simply adding darwin-x86-64 and aarch64 as new targets to keep things moving. At some point I can make a PR to remove the darwin target once the dust has settled a bit and seems to be stable.

@ncalexan
Copy link
Member

This landed and is, I believe, working well for application-services.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants