Add aarch64 target for darwin desktops #78
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ncalexan What do you think of going the darwin + darwin-{x86_64, aarch64} vs just removing the darwin target (breaking change) and only have the darwin with the modifiers? Curious your thoughts! |
ncalexan
approved these changes
Jan 11, 2022
There was a problem hiding this comment.
Just nits -- everything looks fine. I'll land this squashed if you prefer to not squash it yourself. I would like to see it rebased onto #81 once those tests are green in automation, the new tests updated to include the new Darwin targets and locations, and repushed to be sure we've got this correct. If you have time, please do it; otherwise, I'll try to get to it shortly.
Thanks, @skhamis!
skhamis
force-pushed
the
m1-darwin-fix
branch
from
041868b to
0bf5f68
Compare
|
Oh -- I cut v0.9.1 with this change as well. Please test and make sure it works for y'all! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #77
Turned out to be a very small patch! Tested with both x86_64 and arm64 JDKs and both seem to compile nicely (the a-s issue mentioned in #77) . The only issue is I don't necessarily know the best way to handle the deprecation of darwin to officially split darwin to use the {-x86_64, -aarch64}. Throwing this up for early visibility....