Add --build-id to the linker flags

[bendk]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1937916 for the reasoning here. I tested this with a Maven local publish and it worked for me.

This could also be behind an option, either one specifically for build-id or a general one like EXTRA_LINKER_ARGS. It seems like build-id is a good default though so I didn't implement it that way on the first pass.

[ncalexan]

I have 2 questions:

1. I guess Rust's linking stage doesn't include a build ID by default? If it doesn't, then I feel like we should put this behind a flag, so that we don't surprise consumers. Or is it that by specifying -Wl at all, we're turning of the Rust default, which would include the build ID?
2. Further, this is a pretty visible change in behaviour. Do you agree that if we enable by default, that means bumping more than the patch version?

[mstange]

1. I guess Rust's linking stage doesn't include a build ID by default? If it doesn't, then I feel like we should put this behind a flag, so that we don't surprise consumers. Or is it that by specifying -Wl at all, we're turning of the Rust default, which would include the build ID?

I haven't tested it myself, but here's a discussion from 2021 which states that Rust by default does not include a build ID: https://internals.rust-lang.org/t/emitting-build-id-when-linking-elf-binaries/15349

[ncalexan]

1. I guess Rust's linking stage doesn't include a build ID by default? If it doesn't, then I feel like we should put this behind a flag, so that we don't surprise consumers. Or is it that by specifying -Wl at all, we're turning of the Rust default, which would include the build ID?

I haven't tested it myself, but here's a discussion from 2021 which states that Rust by default does not include a build ID: https://internals.rust-lang.org/t/emitting-build-id-when-linking-elf-binaries/15349

OK. I'd be happier making this opt-in. @bendk?

[bendk]

Sounds good, I just updated the PR to make this optional.

One issue I noticed is that there seems to be an issue with stale objects. In order for the change to take effect I needed to run cargo clean, then ./gradlew assembleDebug twice. Any idea what's going on here and how I can fix it?

[bendk]

Any suggestions on how to better describe this? I think a link would be great, but when I did a quick search I didn't find a good page to send people to.

[bendk]

I'm also open to changing the config name.

[ncalexan]

I don't see a better link either; maybe https://linux.die.net/man/1/ld? I see some options, but that can be for the next person to monkey with.

[ncalexan]

Fine by me. Do you know how to cut a release? There are docs in the repo, give it a try?

[ncalexan]

I don't see a better link either; maybe https://linux.die.net/man/1/ld? I see some options, but that can be for the next person to monkey with.

[bendk]

Fine by me. Do you know how to cut a release? There are docs in the repo, give it a try?

Sounds good, let's see what happens.