Skip to content

Count closures arguments for the NArgs metric #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 16, 2021
Merged

Count closures arguments for the NArgs metric #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5f3f49
Rename fn_args to args
Luni-4 Sep 16, 2021
be5b6ba
Count closures arguments for the NArgs metric
Luni-4 Sep 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions rust-code-analysis-web/src/web/server.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -633,7 +633,7 @@ mod tests {
"end_line": 4,
"metrics": {"cyclomatic": {"sum": 2.0, "average": 1.0},
"cognitive": {"sum": 0.0, "average": 0.0},
"nargs": {"sum": 0.0, "average": 0.0},
"nargs": {"total_functions": 0.0, "average_functions": 0.0, "total_closures": 0.0, "average_closures": 0.0, "total": 0.0, "average": 0.0},
"nexits": {"sum": 0.0, "average": 0.0},
"halstead": {"bugs": 0.000_942_552_557_372_941_4,
"difficulty": 1.0,
Expand All @@ -660,7 +660,7 @@ mod tests {
"end_line": 4,
"metrics": {"cyclomatic": {"sum": 1.0, "average": 1.0},
"cognitive": {"sum": 0.0, "average": 0.0},
"nargs": {"sum": 0.0, "average": 0.0},
"nargs": {"total_functions": 0.0, "average_functions": 0.0, "total_closures": 0.0, "average_closures": 0.0, "total": 0.0, "average": 0.0},
"nexits": {"sum": 0.0, "average": 0.0},
"halstead": {"bugs": 0.000_942_552_557_372_941_4,
"difficulty": 1.0,
Expand Down Expand Up @@ -713,7 +713,7 @@ mod tests {
"end_line": 2,
"metrics": {"cyclomatic": {"sum": 2.0, "average": 1.0},
"cognitive": {"sum": 0.0, "average": 0.0},
"nargs": {"sum": 0.0, "average": 0.0},
"nargs": {"total_functions": 0.0, "average_functions": 0.0, "total_closures": 0.0, "average_closures": 0.0, "total": 0.0, "average": 0.0},
"nexits": {"sum": 0.0, "average": 0.0},
"halstead": {"bugs": 0.000_942_552_557_372_941_4,
"difficulty": 1.0,
Expand Down Expand Up @@ -762,7 +762,7 @@ mod tests {
"end_line": 2,
"metrics": {"cyclomatic": {"sum": 2.0, "average": 1.0},
"cognitive": {"sum": 0.0, "average": 0.0},
"nargs": {"sum": 0.0, "average": 0.0},
"nargs": {"total_functions": 0.0, "average_functions": 0.0, "total_closures": 0.0, "average_closures": 0.0, "total": 0.0, "average": 0.0},
"nexits": {"sum": 0.0, "average": 0.0},
"halstead": {"bugs": 0.000_942_552_557_372_941_4,
"difficulty": 1.0,
Expand All @@ -789,7 +789,7 @@ mod tests {
"end_line": 2,
"metrics": {"cyclomatic": {"sum": 1.0, "average": 1.0},
"cognitive": {"sum": 0.0, "average": 0.0},
"nargs": {"sum": 0.0, "average": 0.0},
"nargs": {"total_functions": 0.0, "average_functions": 0.0, "total_closures": 0.0, "average_closures": 0.0, "total": 0.0, "average": 0.0},
"nexits": {"sum": 0.0, "average": 0.0},
"halstead": {"bugs": 0.000_942_552_557_372_941_4,
"difficulty": 1.0,
Expand Down
2 changes: 1 addition & 1 deletion src/checker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,5 +351,5 @@ impl Checker for RustCode {
TraitItem,
ClosureExpression
);
mk_checker!(is_non_arg, LPAREN, COMMA, RPAREN, AttributeItem);
mk_checker!(is_non_arg, LPAREN, COMMA, RPAREN, PIPE, AttributeItem);
}
192 changes: 0 additions & 192 deletions src/metrics/fn_args.rs
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion src/metrics/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
pub mod cognitive;
pub mod cyclomatic;
pub mod exit;
pub mod fn_args;
pub mod halstead;
pub mod loc;
pub mod mi;
pub mod nargs;
pub mod nom;
Loading