Fix JavaScript nom #373
Merged
Fix JavaScript nom #373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
- Coverage 53.30% 53.13% -0.18%
==========================================
Files 45 45
Lines 3617 3672 +55
Branches 861 883 +22
==========================================
+ Hits 1928 1951 +23
- Misses 1127 1149 +22
- Partials 562 572 +10
Continue to review full report at Codecov.
|
marco-c
reviewed
Nov 26, 2020
marco-c
reviewed
Nov 26, 2020
Luni-4
force-pushed
the
fix-nom
branch
2 times, most recently
from
53ce789 to
725db0c
Compare
Collaborator
Author
|
More tests need to be added https://community-tc.services.mozilla.com/api/queue/v1/task/ERRqGSILRqOw2VizPXuD7A/runs/0/artifacts/public%2Fjson-diffs-and-minimal-tests.tar.gz |
Luni-4
force-pushed
the
fix-nom
branch
4 times, most recently
from
723d721 to
d9c920b
Compare
Collaborator
Author
|
Fixed every regression, please have a look at the |
marco-c
reviewed
Sep 16, 2021
marco-c
reviewed
Sep 16, 2021
marco-c
reviewed
Sep 16, 2021
marco-c
reviewed
Sep 16, 2021
calixteman
reviewed
Sep 16, 2021
calixteman
reviewed
Sep 16, 2021
calixteman
reviewed
Sep 16, 2021
calixteman
previously approved these changes
Sep 16, 2021
Collaborator
calixteman
left a comment
calixteman
left a comment
There was a problem hiding this comment.
r+, with comments addressed and green CI.
marco-c
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were not counting closures in the correct way