Skip to content

Refactor nom metric #675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2021
Merged

Refactor nom metric #675

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 98 additions & 38 deletions src/checker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,82 @@ use regex::bytes::Regex;

use crate::*;

#[inline(always)]
fn is_child(node: &Node, id: u16) -> bool {
node.object()
.children(&mut node.object().walk())
.any(|child| child.kind_id() == id)
}

#[inline(always)]
fn has_sibling(node: &Node, id: u16) -> bool {
node.object().parent().map_or(false, |parent| {
node.object()
.children(&mut parent.walk())
.any(|child| child.kind_id() == id)
})
}

macro_rules! check_if_func {
($node: ident) => {
count_specific_ancestors!(
$node,
VariableDeclarator | AssignmentExpression | LabeledStatement | Pair,
StatementBlock | ReturnStatement | NewExpression | Arguments
) > 0
|| is_child($node, Identifier as u16)
};
}

macro_rules! check_if_arrow_func {
($node: ident) => {
count_specific_ancestors!(
$node,
VariableDeclarator | AssignmentExpression | LabeledStatement,
StatementBlock | ReturnStatement | NewExpression | CallExpression
) > 0
|| has_sibling($node, PropertyIdentifier as u16)
};
}

macro_rules! is_js_func {
($node: ident) => {
match $node.object().kind_id().into() {
FunctionDeclaration | MethodDefinition => true,
Function => check_if_func!($node),
ArrowFunction => check_if_arrow_func!($node),
_ => false,
}
};
}

macro_rules! is_js_closure {
($node: ident) => {
match $node.object().kind_id().into() {
GeneratorFunction | GeneratorFunctionDeclaration => true,
Function => !check_if_func!($node),
ArrowFunction => !check_if_arrow_func!($node),
_ => false,
}
};
}

macro_rules! is_js_func_and_closure_checker {
($grammar: ident) => {
#[inline(always)]
fn is_func(node: &Node) -> bool {
use $grammar::*;
is_js_func!(node)
}

#[inline(always)]
fn is_closure(node: &Node) -> bool {
use $grammar::*;
is_js_closure!(node)
}
};
}

pub trait Checker {
fn is_comment(node: &Node) -> bool;

Expand All @@ -19,6 +95,7 @@ pub trait Checker {
fn is_string(node: &Node) -> bool;
fn is_call(node: &Node) -> bool;
fn is_func(node: &Node) -> bool;
fn is_closure(node: &Node) -> bool;
fn is_func_space(node: &Node) -> bool;
fn is_non_arg(node: &Node) -> bool;

Expand All @@ -32,6 +109,7 @@ impl Checker for PreprocCode {
mk_checker!(is_string, StringLiteral, RawStringLiteral);
mk_checker!(is_call,);
mk_checker!(is_func,);
mk_checker!(is_closure,);
mk_checker!(is_func_space,);
mk_checker!(is_non_arg,);
}
Expand All @@ -41,6 +119,7 @@ impl Checker for CcommentCode {
mk_checker!(is_string, StringLiteral, RawStringLiteral);
mk_checker!(is_call,);
mk_checker!(is_func,);
mk_checker!(is_closure,);
mk_checker!(is_func_space,);
mk_checker!(is_non_arg,);

Expand All @@ -66,8 +145,11 @@ impl Checker for CppCode {
is_func,
FunctionDefinition,
FunctionDefinition2,
FunctionDefinition3
FunctionDefinition3,
FunctionDefinition4,
FunctionDefinitionRepeat1
);
mk_checker!(is_closure, LambdaExpression);
mk_checker!(
is_func_space,
TranslationUnit,
Expand Down Expand Up @@ -106,6 +188,7 @@ impl Checker for PythonCode {
mk_checker!(is_string, String, ConcatenatedString);
mk_checker!(is_call, Call);
mk_checker!(is_func, FunctionDefinition);
mk_checker!(is_closure, Lambda);
mk_checker!(is_func_space, Module, FunctionDefinition, ClassDefinition);
mk_checker!(is_non_arg, LPAREN, COMMA, RPAREN);
}
Expand All @@ -115,6 +198,7 @@ impl Checker for JavaCode {
mk_checker!(is_string, StringLiteral);
mk_checker!(is_call, MethodInvocation);
mk_checker!(is_func, MethodDeclaration);
mk_checker!(is_closure,);
mk_checker!(is_func_space, Program, ClassDeclaration);
mk_checker!(is_non_arg,);
}
Expand All @@ -123,15 +207,7 @@ impl Checker for MozjsCode {
mk_checker!(is_comment, Comment);
mk_checker!(is_string, String, TemplateString);
mk_checker!(is_call, CallExpression);
mk_checker!(
is_func,
Function,
GeneratorFunction,
FunctionDeclaration,
GeneratorFunctionDeclaration,
MethodDefinition,
ArrowFunction
);

mk_checker!(
is_func_space,
Program,
Expand All @@ -145,6 +221,8 @@ impl Checker for MozjsCode {
ArrowFunction
);

is_js_func_and_closure_checker!(Mozjs);

#[inline(always)]
fn is_else_if(node: &Node) -> bool {
if node.object().kind_id() != <Self as TSLanguage>::BaseLang::IfStatement {
Expand All @@ -162,15 +240,6 @@ impl Checker for JavascriptCode {
mk_checker!(is_comment, Comment);
mk_checker!(is_string, String, TemplateString);
mk_checker!(is_call, CallExpression);
mk_checker!(
is_func,
Function,
GeneratorFunction,
FunctionDeclaration,
GeneratorFunctionDeclaration,
MethodDefinition,
ArrowFunction
);
mk_checker!(
is_func_space,
Program,
Expand All @@ -183,6 +252,9 @@ impl Checker for JavascriptCode {
ClassDeclaration,
ArrowFunction
);

is_js_func_and_closure_checker!(Javascript);

mk_else_if!(IfStatement);
mk_checker!(is_non_arg, LPAREN, COMMA, RPAREN);
}
Expand All @@ -191,15 +263,6 @@ impl Checker for TypescriptCode {
mk_checker!(is_comment, Comment);
mk_checker!(is_string, String, TemplateString);
mk_checker!(is_call, CallExpression);
mk_checker!(
is_func,
Function,
GeneratorFunction,
FunctionDeclaration,
GeneratorFunctionDeclaration,
MethodDefinition,
ArrowFunction
);
mk_checker!(
is_func_space,
Program,
Expand All @@ -213,6 +276,8 @@ impl Checker for TypescriptCode {
ArrowFunction
);

is_js_func_and_closure_checker!(Typescript);

#[inline(always)]
fn is_else_if(node: &Node) -> bool {
if node.object().kind_id() != <Self as TSLanguage>::BaseLang::IfStatement {
Expand All @@ -230,15 +295,6 @@ impl Checker for TsxCode {
mk_checker!(is_comment, Comment);
mk_checker!(is_string, String, TemplateString);
mk_checker!(is_call, CallExpression);
mk_checker!(
is_func,
Function,
GeneratorFunction,
FunctionDeclaration,
GeneratorFunctionDeclaration,
MethodDefinition,
ArrowFunction
);
mk_checker!(
is_func_space,
Program,
Expand All @@ -252,6 +308,9 @@ impl Checker for TsxCode {
ClassDeclaration,
ArrowFunction
);

is_js_func_and_closure_checker!(Tsx);

mk_else_if!(IfStatement);
mk_checker!(is_non_arg, LPAREN, COMMA, RPAREN);
}
Expand Down Expand Up @@ -282,7 +341,8 @@ impl Checker for RustCode {
}
mk_checker!(is_string, StringLiteral, RawStringLiteral);
mk_checker!(is_call, CallExpression);
mk_checker!(is_func, FunctionItem, ClosureExpression);
mk_checker!(is_func, FunctionItem);
mk_checker!(is_closure, ClosureExpression);
mk_checker!(
is_func_space,
SourceFile,
Expand Down
Loading