Add averages for Nom metrics #736
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #736 +/- ##
==========================================
+ Coverage 37.95% 38.43% +0.47%
==========================================
Files 51 51
Lines 6549 6611 +62
Branches 963 965 +2
==========================================
+ Hits 2486 2541 +55
- Misses 3403 3407 +4
- Partials 660 663 +3
Continue to review full report at Codecov.
|
marco-ballario
force-pushed
the
average-sum-metrics
branch
from
4214f77 to
003b5dc
Compare
calixteman
previously approved these changes
Jan 10, 2022
Collaborator
calixteman
left a comment
calixteman
left a comment
There was a problem hiding this comment.
LGTM. Thank you for doing this.
Collaborator
|
@marco-ballario could you rebase please ? |
marco-ballario
force-pushed
the
average-sum-metrics
branch
from
003b5dc to
d8e466e
Compare
calixteman
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds some averages calculations for the Nom metrics. Averages are calculated over spaces, like for the Cyclomatic metric. Tests have been updated accordingly. This PR should partly resolve issue #409 . Thanks in advance for the review.