Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

compiler::gcc::test::test_parse_arguments_multiarch_cache_disabled fails intermittently #1982

Closed
glandium opened this issue Nov 22, 2023 · 0 comments · Fixed by #1984
Closed

compiler::gcc::test::test_parse_arguments_multiarch_cache_disabled fails intermittently #1982

glandium opened this issue Nov 22, 2023 · 0 comments · Fixed by #1984

Comments

@glandium
Copy link
Collaborator

The result of that test depends on the SCCACHE_CACHE_MULTIARCH environment variable. Ignoring the fact that setting the environment variable outside of cargo test makes the test permanently fail, there's another problem: other tests are temporarily setting SCCACHE_CACHE_MULTIARCH, and tests run in parallel. So there's a race condition: if test_parse_arguments_multiarch_cache_disabled runs at the same time as some of these other tests, it fails, otherwise, it passes.
@glandium glandium mentioned this issue Nov 22, 2023
Merged
glandium added a commit to glandium/sccache that referenced this issue Nov 23, 2023
@glandium
Fix test_parse_arguments_multiarch_cache_disabled
0ddbb91 
The test fails when SCCACHE_CACHE_MULTIARCH is set, which can either
happen externally, or when another tests sets it via with_var.

with_var_unset prevents both (temp_env has a global lock specifically
to avoid the problem with concurrent tests).

Fixes mozilla#1982
@glandium glandium mentioned this issue Nov 23, 2023
Merged
glandium added a commit that referenced this issue Nov 23, 2023
@glandium
Fix test_parse_arguments_multiarch_cache_disabled
e5fde16 
The test fails when SCCACHE_CACHE_MULTIARCH is set, which can either
happen externally, or when another tests sets it via with_var.

with_var_unset prevents both (temp_env has a global lock specifically
to avoid the problem with concurrent tests).

Fixes #1982
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix test_parse_arguments_multiarch_cache_disabled glandium/sccache
1 participant
@glandium