Support using authentication on s3 get requests #217
Comments
|
Yeah, I would like to be able to preserve the existing behavior, it's what we use in Firefox CI (our s3 buckets are world-readable). It's slightly faster to do unauthenticated GET requests if possible. I'd love to support this as well, though. We've been hung up for a while by sccache not supporting a config file, which would make it much more straightforward to have nontrivial configurations. |
|
#135 implements this feature in a configurable manner. I've been maintaining my fork which includes it for use in my company's build pipeline until it gets merged. |
Closed
jschwe
added a commit
to jschwe/sccache
that referenced
this issue
Feb 12, 2022
The changelog only consists of: > Update to digest v0.10 (mozilla#217) So this one should be pretty safe Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
jschwe
added a commit
to jschwe/sccache
that referenced
this issue
Feb 12, 2022
The changelog only consists of: > Update to digest v0.10 (mozilla#217) So this one should be pretty safe Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
sylvestre
pushed a commit
that referenced
this issue
Feb 12, 2022
The changelog only consists of: > Update to digest v0.10 (#217) So this one should be pretty safe Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
|
Has been implemented. cc @sylvestre Please close this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Our s3 bucket requires authorization for get requests as well, and I noticed that the s3 implementation only sets authorization for put requests. I have a change that uses credentials for the get requests as well, but I'm not sure if this needs to be configurable (e.g. only use credentials for get requests if some environment variable is set).
johnklai1@8660c00
The text was updated successfully, but these errors were encountered: