Support -Xclang -no-opaque-pointers in clang
#1181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some projects, such as chromium, have recently been using `-Xclang -no-opaque-pointers` [1] to deal with the issue of changing opaque pointers in llvm[2], but the current sccache cannot handle that flag. This patch is to teach sccache to parse those flags so that it can solve issues like [3]. [1] https://chromium-review.googlesource.com/c/chromium/src/+/3584317 [2] https://llvm.org/docs/OpaquePointers.html [3] denoland/rusty_v8#971
Codecov Report
@@ Coverage Diff @@
## main #1181 +/- ##
==========================================
- Coverage 29.15% 28.79% -0.37%
==========================================
Files 47 47
Lines 16735 16736 +1
Branches 8013 8008 -5
==========================================
- Hits 4879 4819 -60
- Misses 6784 6827 +43
- Partials 5072 5090 +18
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some projects, such as chromium, have recently been using
-Xclang -no-opaque-pointers[1] to deal with the issue of changingopaque pointers in llvm[2], but the current sccache cannot handle that
flag.
This patch is to teach sccache to parse those flags so that it can solve
issues like [3].
[1] https://chromium-review.googlesource.com/c/chromium/src/+/3584317
[2] https://llvm.org/docs/OpaquePointers.html
[3] denoland/rusty_v8#971