Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facilitate the usage of direct access/mode #1939

Merged
merged 4 commits into from
Nov 6, 2023
Merged

Conversation

sylvestre
Copy link
Collaborator

No description provided.

@sylvestre
Copy link
Collaborator Author

@Alphare ok with you?

@Alphare
Copy link
Contributor

Alphare commented Nov 6, 2023

Couple of nits, but otherwise looks like an improvement in user-friendliness.

src/server.rs Outdated Show resolved Hide resolved
src/config.rs Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (c5d1ab4) 29.70% compared to head (383de96) 29.68%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1939      +/-   ##
==========================================
- Coverage   29.70%   29.68%   -0.03%     
==========================================
  Files          51       51              
  Lines       18883    19143     +260     
  Branches     9072     9243     +171     
==========================================
+ Hits         5610     5683      +73     
- Misses       7882     7970      +88     
- Partials     5391     5490      +99     
Files Coverage Δ
tests/harness/mod.rs 44.82% <ø> (+3.44%) ⬆️
src/commands.rs 16.90% <0.00%> (+0.04%) ⬆️
src/config.rs 27.45% <0.00%> (ø)
src/server.rs 31.45% <50.00%> (+0.86%) ⬆️

... and 14 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit cb7f752 into mozilla:main Nov 6, 2023
@sylvestre sylvestre deleted the direct branch November 6, 2023 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants