Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail early if the local daemon doesn't start properly during tests #1963

Merged
merged 1 commit into from
Nov 14, 2023

Conversation

glandium
Copy link
Collaborator

This unveils a problem that has been hidden in plain sight for a while, and will be fixed separately.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (1d71d5d) 29.97% compared to head (e099038) 30.00%.

Files Patch % Lines
tests/harness/mod.rs 0.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1963      +/-   ##
==========================================
+ Coverage   29.97%   30.00%   +0.02%     
==========================================
  Files          51       51              
  Lines       19152    19153       +1     
  Branches     9224     9222       -2     
==========================================
+ Hits         5741     5747       +6     
  Misses       7958     7958              
+ Partials     5453     5448       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sylvestre sylvestre merged commit 01bfa41 into mozilla:main Nov 14, 2023
36 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants