Catch panics in the server and transmit them as errors to the client. #1981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1981 +/- ##
==========================================
- Coverage 30.69% 30.60% -0.09%
==========================================
Files 51 51
Lines 19192 19215 +23
Branches 9230 9248 +18
==========================================
- Hits 5891 5881 -10
- Misses 7760 7790 +30
- Partials 5541 5544 +3 ☔ View full report in Codecov by Sentry. |
glandium
force-pushed
the
panic
branch
2 times, most recently
from
d004af4 to
6f0514a
Compare
Currently, when the server panics, the client never gets a response, and the compilation gets stuck. The only indication of something going wrong is in the logs if they are enabled. With this change, the error is transmitted to the client, which then fails and prints it. For instance, one of the out-of-bound accesses fixed in mozilla#1980 now prints this on the client side before returning a non-zero exit code: sccache: encountered fatal error sccache: error: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 sccache: caused by: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1 Fixes mozilla#756
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when the server panics, the client never gets a response, and the compilation gets stuck. The only indication of something going wrong is in the logs if they are enabled.
With this change, the error is transmitted to the client, which then fails and prints it. For instance, one of the out-of-bound accesses fixed in #1980 now prints this on the client side before returning a non-zero exit code:
sccache: encountered fatal error
sccache: error: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1
sccache: caused by: thread 'tokio-runtime-worker' panicked at src/compiler/c.rs:612:25: range end index 7 out of range for slice of length 1
Fixes #756