Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for symlinks in toolchains. #2030

Merged
merged 1 commit into from
Jan 17, 2024

Conversation

afranchuk
Copy link
Contributor

Closes #2028.

@sylvestre
Copy link
Collaborator

@afranchuk nice to see you here :)

@sylvestre
Copy link
Collaborator

would it be possible to add a test ?

@codecov-commenter
Copy link

codecov-commenter commented Jan 12, 2024

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (b260af4) 30.64% compared to head (49c2e53) 30.99%.
Report is 5 commits behind head on main.

Files Patch % Lines
src/dist/pkg.rs 15.90% 33 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2030      +/-   ##
==========================================
+ Coverage   30.64%   30.99%   +0.34%     
==========================================
  Files          51       51              
  Lines       19638    19639       +1     
  Branches     9428     9437       +9     
==========================================
+ Hits         6018     6087      +69     
+ Misses       8011     7891     -120     
- Partials     5609     5661      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@afranchuk
Copy link
Contributor Author

would it be possible to add a test ?

The thought crossed my mind, but superficially it seems like it'd be a bit tricky. There are no existing tests for any of the packaging, so I'd have to build the boilerplate for mocking an existing filesystem from which the toolchain is created. But if you'd like to see some tests I can be the first to fill that gap!

@sylvestre sylvestre merged commit 13b018f into mozilla:main Jan 17, 2024
48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Symlinks in the sysroot can prevent auto-packaged toolchains from working correctly
3 participants