-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cache/oss): add support for oss #2046
Conversation
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2046 +/- ##
==========================================
- Coverage 30.86% 30.58% -0.29%
==========================================
Files 51 52 +1
Lines 19653 19451 -202
Branches 9455 9326 -129
==========================================
- Hits 6066 5949 -117
+ Misses 7852 7841 -11
+ Partials 5735 5661 -74 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Chojan Shang <psiace@apache.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot!
cc @sylvestre, would you like to take a review? OSS doesn't provide something like minio or localstack, so we can't test it in CI. |
Some minor nits :) |
Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
thanks for your work! |
Fixes: #2043