Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cache/oss): add support for oss #2046

Merged
merged 7 commits into from
Jan 22, 2024
Merged

feat(cache/oss): add support for oss #2046

merged 7 commits into from
Jan 22, 2024

Conversation

PsiACE
Copy link
Contributor

@PsiACE PsiACE commented Jan 19, 2024

  • add basic support for oss, pass local test
  • polish impl & docs
  • add test workflow

Fixes: #2043

Signed-off-by: Chojan Shang <psiace@apache.org>
README.md Outdated Show resolved Hide resolved
docs/OSS.md Outdated Show resolved Hide resolved
src/cache/oss.rs Show resolved Hide resolved
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
Signed-off-by: Chojan Shang <psiace@apache.org>
@codecov-commenter
Copy link

codecov-commenter commented Jan 21, 2024

Codecov Report

Attention: 68 lines in your changes are missing coverage. Please review.

Comparison is base (8d3cd35) 30.86% compared to head (cfa3d52) 30.58%.

Files Patch % Lines
src/config.rs 11.53% 33 Missing and 13 partials ⚠️
src/cache/oss.rs 0.00% 12 Missing ⚠️
src/cache/cache.rs 0.00% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2046      +/-   ##
==========================================
- Coverage   30.86%   30.58%   -0.29%     
==========================================
  Files          51       52       +1     
  Lines       19653    19451     -202     
  Branches     9455     9326     -129     
==========================================
- Hits         6066     5949     -117     
+ Misses       7852     7841      -11     
+ Partials     5735     5661      -74     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Chojan Shang <psiace@apache.org>
@PsiACE PsiACE requested a review from Xuanwo January 21, 2024 16:16
@PsiACE PsiACE marked this pull request as ready for review January 21, 2024 16:16
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo
Copy link
Collaborator

Xuanwo commented Jan 21, 2024

cc @sylvestre, would you like to take a review? OSS doesn't provide something like minio or localstack, so we can't test it in CI.

docs/OSS.md Outdated Show resolved Hide resolved
docs/OSS.md Outdated Show resolved Hide resolved
@sylvestre
Copy link
Collaborator

Some minor nits :)

Co-authored-by: Sylvestre Ledru <sylvestre@debian.org>
@PsiACE PsiACE requested a review from sylvestre January 22, 2024 13:29
@sylvestre sylvestre merged commit 4d81257 into mozilla:main Jan 22, 2024
48 checks passed
@PsiACE PsiACE deleted the oss branch January 22, 2024 13:31
@sylvestre
Copy link
Collaborator

thanks for your work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add native aliyun oss support (mentorship available)
4 participants