-
Notifications
You must be signed in to change notification settings - Fork 552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rustc driver detection - includes #1897 #2085
Conversation
It would be nice to update the commit to explicit why we are doing it |
The commit or the PR desc? Squash merge 'd be fine by me. |
The commit please |
de6aa41
to
cbe79c9
Compare
Is the above sufficient @sylvestre ? I'd still be in favor of squash this PR, left the two commits separate for no particular reason other than authorship |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2085 +/- ##
==========================================
+ Coverage 30.77% 32.17% +1.40%
==========================================
Files 52 53 +1
Lines 19913 20721 +808
Branches 9630 10296 +666
==========================================
+ Hits 6129 6668 +539
+ Misses 7959 7877 -82
- Partials 5825 6176 +351 ☔ View full report in Codecov by Sentry. |
cbe79c9
to
9701f53
Compare
The coverage report is obsolete, it actually improved marginally. CC @sylvestre anything missing/insufficient, otherwise I'd merge with rebase? |
If we are not sure it's rustc like and we check -vV output to accept valid rustc drivers. Simplifies #1897 .
Fixes #861