Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Unify env bool processing #2103

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Feb 21, 2024

  • Unify env bool processing
  • Upper & mixed-case values are also accepted
  • Actualize main readme file with the latest feature list location
  • Return some missed spaces

@codecov-commenter
Copy link

codecov-commenter commented Feb 21, 2024

Codecov Report

Attention: 18 lines in your changes are missing coverage. Please review.

Comparison is base (6ebc516) 30.89% compared to head (fbb9b60) 30.63%.

Files Patch % Lines
src/config.rs 18.18% 7 Missing and 11 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2103      +/-   ##
==========================================
- Coverage   30.89%   30.63%   -0.27%     
==========================================
  Files          53       53              
  Lines       20033    20011      -22     
  Branches     9717     9697      -20     
==========================================
- Hits         6189     6130      -59     
+ Misses       7947     7932      -15     
- Partials     5897     5949      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

* Actualize main readme file with the latest feature list location
* Return some missed spaces
@AJIOB AJIOB force-pushed the AJIOB/unify-env-bool-processing branch from a4ea8f0 to fbb9b60 Compare February 21, 2024 13:18
Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 458b0af into mozilla:main Feb 22, 2024
49 checks passed
@AJIOB AJIOB deleted the AJIOB/unify-env-bool-processing branch February 22, 2024 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants