Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Memcached authentication #2117

Merged
merged 1 commit into from
Mar 4, 2024
Merged

Conversation

AJIOB
Copy link
Contributor

@AJIOB AJIOB commented Mar 3, 2024

Must be merged only after #2114 and #2116, because this branch contains changes from both PRs.

@codecov-commenter
Copy link

codecov-commenter commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 5.71429% with 33 lines in your changes are missing coverage. Please review.

Project coverage is 30.73%. Comparing base (0cc0c62) to head (b5d13f2).
Report is 7 commits behind head on main.

Files Patch % Lines
src/config.rs 9.52% 10 Missing and 9 partials ⚠️
src/cache/cache.rs 0.00% 9 Missing ⚠️
src/cache/memcached.rs 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2117      +/-   ##
==========================================
- Coverage   30.91%   30.73%   -0.18%     
==========================================
  Files          53       53              
  Lines       20112    20184      +72     
  Branches     9755     9805      +50     
==========================================
- Hits         6217     6204      -13     
- Misses       7922     7979      +57     
- Partials     5973     6001      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/Memcached.md Outdated Show resolved Hide resolved
@AJIOB AJIOB force-pushed the AJIOB/memcached-auth branch 2 times, most recently from cb0e9ae to 44964f4 Compare March 3, 2024 12:54
@AJIOB AJIOB marked this pull request as ready for review March 3, 2024 12:55
* Add new env variables for memcached.
* Unify memcached endpoint env var name.
@AJIOB AJIOB force-pushed the AJIOB/memcached-auth branch from 44964f4 to b5d13f2 Compare March 4, 2024 07:29
@AJIOB
Copy link
Contributor Author

AJIOB commented Mar 4, 2024

@sylvestre & @Xuanwo, recheck it, please.

I think it is ready to be merged.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@Xuanwo Xuanwo merged commit e747592 into mozilla:main Mar 4, 2024
52 checks passed
@AJIOB AJIOB deleted the AJIOB/memcached-auth branch March 4, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants