Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add required winapi features #2160

Merged
merged 1 commit into from
Apr 27, 2024
Merged

Conversation

Systemcluster
Copy link
Contributor

Currently cargo install sccache fails due to missing winapi features:

error[E0432]: unresolved import `winapi::um::processenv`
   --> C:\Users\x\.cargo\registry\src\index.crates.io-6f17d22bba15001f\sccache-0.8.0\src\commands.rs:136:21
    |
136 |     use winapi::um::processenv::SetStdHandle;
    |                     ^^^^^^^^^^ could not find `processenv` in `um`

This is due to the recent winapi-utils update removing its winapi depencency, which before, through feature-unification, made them available to sccache: BurntSushi/winapi-util@732de05

Both "processenv" and "std" are required to compile.

@Xuanwo
Copy link
Collaborator

Xuanwo commented Apr 26, 2024

Hi, please try installing sccache via cargo install sccache --locked. Otherwise, you are install sccache with the latest version instead of the one we tested and locked.

@codecov-commenter
Copy link

codecov-commenter commented Apr 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.92%. Comparing base (0cc0c62) to head (63d8bc7).
Report is 21 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2160       +/-   ##
===========================================
+ Coverage   30.91%   43.92%   +13.01%     
===========================================
  Files          53       53               
  Lines       20112    20348      +236     
  Branches     9755     9705       -50     
===========================================
+ Hits         6217     8938     +2721     
+ Misses       7922     7889       -33     
+ Partials     5973     3521     -2452     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 887ae90 into mozilla:main Apr 27, 2024
53 checks passed
@Systemcluster Systemcluster deleted the fix-windows branch April 27, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants