Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid keeping lock while writing to disk cache #2193

Merged
merged 1 commit into from
Jun 6, 2024

Conversation

glandium
Copy link
Collaborator

This splits the insertion operation into two separate operations, so that the lock can be released while performing I/O.

This splits the insertion operation into two separate operations, so
that the lock can be released while performing I/O.
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 75.72816% with 25 lines in your changes are missing coverage. Please review.

Project coverage is 42.77%. Comparing base (0cc0c62) to head (12e16e7).
Report is 45 commits behind head on main.

Files Patch % Lines
src/lru_disk_cache/mod.rs 73.62% 4 Missing and 20 partials ⚠️
src/cache/disk.rs 90.90% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2193       +/-   ##
===========================================
+ Coverage   30.91%   42.77%   +11.86%     
===========================================
  Files          53       53               
  Lines       20112    20412      +300     
  Branches     9755     9725       -30     
===========================================
+ Hits         6217     8731     +2514     
- Misses       7922     7982       +60     
+ Partials     5973     3699     -2274     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@glandium glandium requested a review from sylvestre May 29, 2024 05:03
@sylvestre sylvestre merged commit 31706d4 into mozilla:main Jun 6, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants