Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Bump MSRV to 1.75 for async in trait #2203

Merged
merged 4 commits into from
Jun 16, 2024

Conversation

Xuanwo
Copy link
Collaborator

@Xuanwo Xuanwo commented Jun 11, 2024

Rust 1.75 was released six months ago and introduced great features such as async in trait. Many of our dependencies, including #2202, are adopting this feature. Let's update our MSRV to 1.75.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from sylvestre June 11, 2024 05:29
@codecov-commenter
Copy link

codecov-commenter commented Jun 11, 2024

Codecov Report

Attention: Patch coverage is 50.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 42.72%. Comparing base (0cc0c62) to head (d7d2d8e).
Report is 48 commits behind head on main.

Files Patch % Lines
src/compiler/nvcc.rs 0.00% 2 Missing ⚠️
src/compiler/nvhpc.rs 0.00% 2 Missing ⚠️
src/compiler/rust.rs 75.00% 1 Missing and 1 partial ⚠️
src/compiler/tasking_vx.rs 0.00% 2 Missing ⚠️
src/compiler/diab.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2203       +/-   ##
===========================================
+ Coverage   30.91%   42.72%   +11.81%     
===========================================
  Files          53       53               
  Lines       20112    20428      +316     
  Branches     9755     9750        -5     
===========================================
+ Hits         6217     8728     +2511     
- Misses       7922     7975       +53     
+ Partials     5973     3725     -2248     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Xuanwo <github@xuanwo.io>
Signed-off-by: Xuanwo <github@xuanwo.io>
@sylvestre sylvestre merged commit 78f3a32 into mozilla:main Jun 16, 2024
53 checks passed
@sylvestre
Copy link
Collaborator

LGTM, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants