Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed --no-default-features --features=gcs warnings #2287

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fixed --no-default-features --features=gcs warnings #2287

wants to merge 1 commit into from

Conversation

Aditya-PS-05
Copy link

@Aditya-PS-05 Aditya-PS-05 commented Nov 12, 2024 •
edited
Loading

closes #2056 and #2100

Summary

Removed the warnings by adding #[allow(dead_code)] attribute.

@sylvestre
Copy link
Collaborator

@Aditya-PS-05 why not fixing it for real ?

@Aditya-PS-05
Copy link
Author

Ok

sylvestre
sylvestre requested changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@sylvestre sylvestre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as said above

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sylvestre sylvestre sylvestre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Building with --no-default-features --features=gcs generates some warnings
2 participants
@Aditya-PS-05 @sylvestre