feat: Add timestamp to .sccache_check name (#2132) #2411
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Xuanwo can you review? Thanks! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2411 +/- ##
==========================================
- Coverage 71.58% 71.57% -0.02%
==========================================
Files 65 65
Lines 36372 36374 +2
==========================================
- Hits 26037 26034 -3
- Misses 10335 10340 +5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
sylvestre
force-pushed
the
issue_2132
branch
from
c15ec99 to
f281164
Compare
sylvestre
force-pushed
the
issue_2132
branch
from
f281164 to
041506a
Compare
Collaborator
|
could you please add tests to make sure we don't regress in the future? thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a unique name for the
.sccache_checkobject so that we don't need to grant overwrite permissions on the bucket.