replace openssl dependency with pem

[nornagon]

fixes #223

[nornagon]

NB. I haven't tested this against actual GCS. But it compiles :D

[luser]

Thanks for the patch! I'm in the middle of trying to get some large pull requests merged, but once those are taken care of I will merge this. It would be good to have someone test against GCS before landing this, though. @cramertj: do you have time for that?

[luser]

If this is landable we could get rid of the silly "all-windows" feature set:

sccache/Cargo.toml

Line 108 in 55210fe

all-windows = ["redis", "s3", "memcached", "azure"]

sccache/appveyor.yml

Line 19 in 55210fe

- cmd: cargo build %RELEASE% --verbose --features="all-windows %EXTRA_FEATURES%"

That's only there because it was too much work to build openssl for Windows, so we're not building gcs in Windows CI.

[nornagon]

Nice! Sounds like a good follow-up PR.

…

On Tue, Aug 28, 2018 at 17:42 Ted Mielczarek ***@***.***> wrote: If this is landable we could get rid of the silly "all-windows" feature set: https://github.com/mozilla/sccache/blob/55210fe1bb61615fdc3aaede47dbe399ddc05794/Cargo.toml#L108 https://github.com/mozilla/sccache/blob/55210fe1bb61615fdc3aaede47dbe399ddc05794/appveyor.yml#L19 That's only there because it was too much work to build openssl for Windows, so we're not building gcs in Windows CI. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#272 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAKjAB1wPTd2SB7bHvulTqkQKpgpz8I7ks5uVXLrgaJpZM4V42nN> .

[luser]

I tested this out locally and it doesn't seem to work, unfortunately. ☹️ I created a GCS bucket and first tested sccache master with it, where it successfully stored a cache entry and was able to retrieve it as a cache hit. Then I built this PR and tried compiling the same source with the same GCS bucket and got the following error in the log:

TRACE:sccache::compiler::compiler: [hello.o]: Hash key: 3be4f5a0edf0f289a81522dde151d2a08d2bbe412ee4af60d48c83f6c7e93c72e5910ce9074232e5fa2b157f2eeeeeaeb3876f3d9f7b008e6e2593da9ca447a7
WARN:sccache::cache::gcs: Got GCS error: Error(Msg("Invalid Key"), State { next_error: None, backtrace: Some(stack backtrace:

<...>

   8:        0x10ef5cdc3 - sccache::cache::gcs::GCSCredentialProvider::credentials::{{closure}}::h4b9a4ddff862ad98
                        at src/cache/gcs.rs:309

Line 309 is here:

sccache/src/cache/gcs.rs

Line 309 in b086c38

Err(e) => Err(e.to_string().into()),

[fxb]

It looks to me like the private key is never converted to DER format, like it was above.

[fxb]

Or is that just the same as decoding the base64 to binary?

[drahnr]

@fxb that's right (assuming you stripped the --- BEGIN... ---END.. pre/post ambles first), there is a good overview at https://knowledge.digicert.com/generalinformation/INFO4448.html about the differences.

[luser]

I merge #367 which fixes this in a different way. Sorry we couldn't get this PR to work!